GitHub Advisoryadvisory · npm
GHSA-23q2-5gf8-gjpp Enabling Authentication does not close all logged in socket connections immediately
LOW
Official page ↗
- Ecosystem
- npm
- Packages
- uptime-kuma
- Severity
- Low
- Weaknesses
- CWE-384
- Reviewed
- 2024-04-19
Affected packages
• npm uptime-kuma: < 1.23.12 → fixed in 1.23.12
Description
Summary
This is basically GHSA-88j4-pcx8-q4q but instead of changing passwords, when enabling authentication.
PoC
• Open Uptime Kuma with authentication disabled
• Enable authentication using another window
• Access the platform using the previously logged-in window
• Note that access (read-write) remains despite the enabled authentication
• Expected behaviour:
• After enabling authentication, all previously connected sessions should be invalidated, requiring users to log in.
• Actual behaviour:
• The system retains sessions and never logs out users unless explicitly done by clicking logout or refreshing the page.
Impact
See GHSA-g9v2-wqcj-j99g and GHSA-88j4-pcx8-q4q
TBH this is quite a niche edge case, so I don't know if this even warrants a security report.
Related
Weakness · CWE (1)
- CWE-384 Session Fixation weakness
References
- https://github.com/louislam/uptime-kuma/security/advisories/GHSA-23q2-5gf8-gjpp web
- https://github.com/louislam/uptime-kuma/security/advisories/GHSA-88j4-pcx8-q4q3 web
- https://github.com/louislam/uptime-kuma/security/advisories/GHSA-g9v2-wqcj-j99g web
- https://github.com/louislam/uptime-kuma/commit/7a9e2f5de69aa0bb884ead25d1dcc833bb8c6579 web
- https://github.com/louislam/uptime-kuma package