GitHub Advisoryadvisory · PyPI
GHSA-26c5-ppr8-f33p Synapse has improper checks for deactivated users during login
MEDIUM
Official page ↗
- Aliases
- CVE-2023-32682
- Ecosystem
- PyPI
- Packages
- matrix-synapse
- Severity
- Moderate
- CVSS vector
- CVSS:3.1/AV:N/AC:L/PR:L/UI:N/S:U/C:L/I:L/A:N
- Weaknesses
- CWE-287
- Reviewed
- 2023-06-06
Affected packages
• PyPI matrix-synapse: < 1.85.0 → fixed in 1.85.0
Description
Impact
It may be possible for a deactivated user to login when using uncommon configurations.
This only applies if any of the following are true:
• JSON Web Tokens are enabled for login via the `jwt_config.enabled` configuration setting
• The local password database is enabled via the `password_config.enabled` and `password_config.localdb_enabled` configuration settings *and* a user's password is updated via an admin API after a user is deactivated.
Note that the local password database is enabled by default, but it is uncommon to set a user's password after they've been deactivated.
Installations that are configured to only allow login via Single Sign-On (SSO) via CAS, SAML or OpenID Connect (OIDC); or via an external password provider (e.g. LDAP) are not affected.
Patches
• If using JSON Web Token logins: #15624
• For other users: #15634
Workarounds
If not using JSON Web Tokens, ensure that deactivated users do not have a password set. This list of users can be queried from PostgreSQL:
```sql
SELECT name FROM users WHERE password_hash IS NOT NULL AND deactivated = 1;
```
Related
Alias · CVE (1)
- CVE-2023-32682 Synapse is a Matrix protocol homeserver written in Python with the Twisted framework. vulnerability
Weakness · CWE (1)
- CWE-287 Improper Authentication weakness
References
- https://github.com/matrix-org/synapse/security/advisories/GHSA-26c5-ppr8-f33p web
- https://nvd.nist.gov/vuln/detail/CVE-2023-32682 advisory
- https://github.com/matrix-org/synapse/issues/12274 web
- https://github.com/matrix-org/synapse/pull/15624 web
- https://github.com/matrix-org/synapse/pull/15634 web
- https://github.com/matrix-org/synapse package
- https://github.com/matrix-org/synapse/releases/tag/v1.85.0 web
- https://github.com/pypa/advisory-database/tree/main/vulns/matrix-synapse/PYSEC-2023-84.yaml web
- https://lists.fedoraproject.org/archives/list/[email protected]/message/X6DH5A5YEB5LRIPP32OUW25FCGZFCZU2 web
- https://matrix-org.github.io/synapse/latest/admin_api/user_admin_api.html#create-or-modify-account web
- https://matrix-org.github.io/synapse/latest/jwt.html web
- https://matrix-org.github.io/synapse/latest/usage/configuration/config_documentation.html#password_config web