GitHub Advisoryadvisory · crates.io
GHSA-27wg-99g8-2v4v Rust EVM erroneousle handles `record_external_operation` error return
MEDIUM
Official page ↗
- Aliases
- CVE-2024-21629
- Ecosystem
- crates.io
- Packages
- evm
- Severity
- Moderate
- CVSS vector
- CVSS:3.1/AV:N/AC:H/PR:N/UI:N/S:U/C:N/I:H/A:N
- Weaknesses
- CWE-703
- Reviewed
- 2024-01-03
Affected packages
• crates.io evm: < 0.41.1 → fixed in 0.41.1
Description
Impact
In `rust-evm`, a feature called `record_external_operation` was introduced, allowing library users to record custom gas changes. This feature can have some bogus interactions with the call stack.
In particular, during finalization of a `CREATE` or `CREATE2`, in the case that the substack execution happens successfully, `rust-evm` will first commit the substate, and then call `record_external_operation(Write(out_code.len()))`. If `record_external_operation` later fails, this error is returned to the parent call stack, instead of `Succeeded`. Yet, the substate commitment already happened. This causes smart contracts able to commit state changes, when the parent caller contract receives zero address (which usually indicates that the execution has failed).
This issue only impacts library users with custom `record_external_operation` that returns errors.
Patches
The issue is patched in release 0.41.1. The commit can be seem here.
Workarounds
None.
References
Patch PR #264.
Related
Alias · CVE (1)
- CVE-2024-21629 Rust EVM is an Ethereum Virtual Machine interpreter. vulnerability
Weakness · CWE (1)
- CWE-703 Improper Check or Handling of Exceptional Conditions weakness
References
- https://github.com/rust-ethereum/evm/security/advisories/GHSA-27wg-99g8-2v4v web
- https://nvd.nist.gov/vuln/detail/CVE-2024-21629 advisory
- https://github.com/rust-ethereum/evm/pull/264 web
- https://github.com/rust-ethereum/evm/commit/d8991ec727ad0fb64fe9957a3cd307387a6701e4 web
- https://github.com/rust-ethereum/evm package
- https://github.com/rust-ethereum/evm/blob/release-v041/src/executor/stack/executor.rs#L1012C25-L1012C69 web