GitHub Advisoryadvisory · Go
GHSA-4f8r-qqr9-fq8j Incorrect delegation lookups can make go-tuf download the wrong artifact
HIGH
Official page ↗
- Aliases
- CVE-2024-47534
- Ecosystem
- Go
- Packages
- github.com/theupdateframework/go-tuf/v2
- Severity
- High
- CVSS vector
- CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:H/A:N
- Weaknesses
- CWE-362
- Reviewed
- 2024-10-01
Affected packages
• Go github.com/theupdateframework/go-tuf/v2: < 2.0.1 → fixed in 2.0.1
Description
During the ongoing work on the TUF conformance test suite, we have come across a test that reveals what we believe is a bug in go-tuf with security implications. The bug exists in go-tuf delegation tracing and could result in downloading the wrong artifact.
We have come across this issue in the test in this PR: https://github.com/theupdateframework/tuf-conformance/pull/115.
The test - `test_graph_traversal` - sets up a repository with a series of delegations, invokes the clients `refresh()` and then checks the order in which the client traced the delegations. The test shows that the go-tuf client inconsistently traces the delegations in a wrong way. For example, during one CI run, the `two-level-delegations` test case triggered a wrong order. The delegations in this look as such:
```python
"two-level-delegations": DelegationsTestCase(
delegations=[
DelegationTester("targets", "A"),
DelegationTester("targets", "B"),
DelegationTester("B", "C"),
],
visited_order=["A", "B", "C"],
),
```
Here, `targets` delegate to `"A"`, and to `"B"`, and `"B"` delegates to `"C"`. The client should trace the delegations in the order `"A"` then `"B"` then `"C"` but in this particular CI run, go-tuf traced the delegations `"B"->"C"->"A"`.
In a subsequent CI run, this test case did not fail, but another one did.
@jku has done a bit of debugging and believes that the returned map of `GetRolesForTarget` returns a map that causes this behavior:
https://github.com/theupdateframework/go-tuf/blob/f95222bdd22d2ac4e5b8ed6fe912b645e213c3b5/metadata/metadata.go#L565-L580
We believe that this map should be an ordered list instead of a map.
Related
Alias · CVE (1)
- CVE-2024-47534 go-tuf is a Go implementation of The Update Framework (TUF). vulnerability
Weakness · CWE (1)
- CWE-362 Concurrent Execution using Shared Resource with Improper Synchronization weakness
References
- https://github.com/theupdateframework/go-tuf/security/advisories/GHSA-4f8r-qqr9-fq8j web
- https://nvd.nist.gov/vuln/detail/CVE-2024-47534 advisory
- https://github.com/theupdateframework/tuf-conformance/pull/115 web
- https://github.com/theupdateframework/go-tuf/commit/edc30b474f5afd4cc603e17149704d5aa605151d web
- https://github.com/theupdateframework/go-tuf/commit/f36420caba9edbfdfd64f95a9554c0836d9cf819 web
- https://github.com/theupdateframework/go-tuf package
- https://github.com/theupdateframework/go-tuf/blob/f95222bdd22d2ac4e5b8ed6fe912b645e213c3b5/metadata/metadata.go#L565-L580 web
- https://pkg.go.dev/vuln/GO-2024-3166 web