GitHub Advisoryadvisory · PyPI
GHSA-4v9q-cgpw-cf38 Multiple evaluation of contract address in call in vyper
HIGH
Official page ↗
- Aliases
- CVE-2022-29255
- Ecosystem
- PyPI
- Packages
- vyper
- Severity
- High
- CVSS vector
- CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:H/A:N
- Weaknesses
- CWE-670
- Reviewed
- 2022-06-06
Affected packages
• PyPI vyper: < 0.3.4 → fixed in 0.3.4
Description
Impact
when a calling an external contract with no return value, the contract address could be evaluated twice. this is usually only an efficiency problem, but if evaluation of the contract address has side effects, it could result in double evaluation of the side effects.
in the following example, `Foo(msg.sender).bar()` is the contract address for the following call (to `.foo()`), and could get evaluated twice
```vyper
interface Foo:
def foo(): nonpayable
def bar() -> address: nonpayable
@external
def do_stuff():
Foo(Foo(msg.sender).bar()).foo()
```
Patches
6b4d8ff185de071252feaa1c319712b2d6577f8d
Workarounds
assign contract addresses to variables. the above example would change to
```vyper
@external
def do_stuff():
t: Foo = Foo(msg.sender).bar()
t.foo()
```
References
For more information
Related
Alias · CVE (1)
- CVE-2022-29255 Vyper is a Pythonic Smart Contract Language for the ethereum virtual machine. vulnerability
Weakness · CWE (1)
- CWE-670 Always-Incorrect Control Flow Implementation weakness
References
- https://github.com/vyperlang/vyper/security/advisories/GHSA-4v9q-cgpw-cf38 web
- https://nvd.nist.gov/vuln/detail/CVE-2022-29255 advisory
- https://github.com/vyperlang/vyper/commit/6b4d8ff185de071252feaa1c319712b2d6577f8d web
- https://github.com/pypa/advisory-database/tree/main/vulns/vyper/PYSEC-2022-43053.yaml web
- https://github.com/vyperlang/vyper package