GitHub Advisoryadvisory · PyPI

GHSA-5824-cm3x-3c38 Vyper has incorrectly allocated named re-entrancy locks

CRITICAL Published 2023-08-09 Modified 2024-10-11 Official page ↗
Aliases
CVE-2023-39363
Ecosystem
PyPI
Packages
vyper
Severity
Critical
CVSS vector
CVSS:3.1/AV:N/AC:H/PR:N/UI:N/S:C/C:N/I:H/A:H
Weaknesses
CWE-863
Reviewed
2023-08-09

Affected packages

• PyPI vyper: >= 0.2.15, < 0.3.1 → fixed in 0.3.1

Description

Impact In versions 0.2.15, 0.2.16 and 0.3.0, named re-entrancy locks are allocated incorrectly. Each function using a named re-entrancy lock gets a unique lock regardless of the key, allowing cross-function re-entrancy in contracts compiled with the susceptible versions. A specific set of conditions is required to result in misbehavior of affected contracts, specifically: • A `.vy` contract compiled with either of the following `vyper` versions: `0.2.15`, `0.2.16`, `0.3.0` • A primary function that utilizes the `@nonreentrant` decorator with a specific `key` and does not strictly follow the check-effects-interaction pattern (i.e. contains an external call to an untrusted party before storage updates) • A secondary function that utilizes the same `key` and would be affected by the improper state caused by the primary function Patches https://github.com/vyperlang/vyper/pull/2439, https://github.com/vyperlang/vyper/pull/2514 Workarounds Upgrade to 0.3.1 or higher References Technical post-mortem report: https://hackmd.io/@vyperlang/HJUgNMhs2

Related

Alias · CVE (1)

  • CVE-2023-39363 Vyper is a Pythonic Smart Contract Language for the Ethereum Virtual Machine (EVM). vulnerability

Weakness · CWE (1)

  • CWE-863 Incorrect Authorization weakness

References