GitHub Advisoryadvisory · Go
GHSA-5r5m-65gx-7vrh otelhttp and otelbeego have DoS vulnerability for high cardinality metrics
HIGH
Official page ↗
- Aliases
- CVE-2023-25151
- Ecosystem
- Go
- Packages
- go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp, go.opentelemetry.io/contrib/instrumentation/github.com/astaxie/beego/otelbeego
- Severity
- High
- CVSS vector
- CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:H
- Weaknesses
- CWE-400
- Reviewed
- 2023-02-08
Affected packages
• Go go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp: >= 0.38.0, < 0.39.0 → fixed in 0.39.0
• Go go.opentelemetry.io/contrib/instrumentation/github.com/astaxie/beego/otelbeego: >= 0.38.0, < 0.39.0 → fixed in 0.39.0
Description
Impact
The v0.38.0 release of `go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp` uses the `httpconv.ServerRequest` function to annotate metric measurements for the `http.server.request_content_length`, `http.server.response_content_length`, and `http.server.duration` instruments.
The `ServerRequest` function sets the `http.target` attribute value to be the whole request URI (including the query string)[^1]. The metric instruments do not "forget" previous measurement attributes when `cumulative` temporality is used, this means the cardinality of the measurements allocated is directly correlated with the unique URIs handled. If the query string is constantly random, this will result in a constant increase in memory allocation that can be used in a denial-of-service attack.
Pseudo-attack:
```
for infinite loop {
r := generate_random_string()
do_http_request("/some/path?random="+r)
}
```
Patches
• `go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp` - v0.39.0
• `go.opentelemetry.io/contrib/instrumentation/github.com/astaxie/beego/otelbeego` - v0.39.0
[^1]: https://github.com/open-telemetry/opentelemetry-go/blob/6cb5718eaaed5c408c3bf4ad1aecee5c20ccdaa9/semconv/internal/v2/http.go#L202-L208
Related
Alias · CVE (1)
- CVE-2023-25151 opentelemetry-go-contrib is a collection of extensions for OpenTelemetry-Go. vulnerability
Weakness · CWE (1)
- CWE-400 Uncontrolled Resource Consumption weakness
References
- https://github.com/open-telemetry/opentelemetry-go-contrib/security/advisories/GHSA-5r5m-65gx-7vrh web
- https://nvd.nist.gov/vuln/detail/CVE-2023-25151 advisory
- https://github.com/open-telemetry/opentelemetry-go-contrib package
- https://github.com/open-telemetry/opentelemetry-go/blob/v1.12.0/semconv/internal/v2/http.go#L159 web