GitHub Advisoryadvisory · Maven
GHSA-8jpx-m2wh-2v34 Remote Code Execution (RCE) vulnerability in dropwizard-validation
HIGH
Official page ↗
- Aliases
- CVE-2020-11002
- Ecosystem
- Maven
- Packages
- io.dropwizard:dropwizard-validation
- Severity
- High
- CVSS vector
- CVSS:3.1/AV:N/AC:H/PR:L/UI:R/S:C/C:H/I:H/A:H
- Weaknesses
- CWE-74
- Reviewed
- 2020-04-10
Affected packages
• Maven io.dropwizard:dropwizard-validation: < 1.3.21 → fixed in 1.3.21
• Maven io.dropwizard:dropwizard-validation: >= 2.0.0, < 2.0.3 → fixed in 2.0.3
Description
Summary
A server-side template injection was identified in the self-validating (`@SelfValidating`) feature of dropwizard-validation enabling attackers to inject arbitrary Java EL expressions, leading to Remote Code Execution (RCE) vulnerability.
If you're using a self-validating bean (via `@SelfValidating`), an upgrade to Dropwizard 1.3.21/2.0.3 or later is strongly recommended.
The changes introduced in Dropwizard 1.3.19 and 2.0.2 (see GHSA-3mcp-9wr4-cjqf/CVE-2020-5245) unfortunately didn't fix the underlying issue completely.
Impact
This issue may allow Remote Code Execution (RCE), allowing to run arbitrary code on the host system (with the privileges of the Dropwizard service account privileges) by injecting arbitrary Java Expression Language (EL) expressions when using the self-validating feature (`@SelfValidating`, `@SelfValidation`) in dropwizard-validation.
Patches
The issue has been fixed in dropwizard-validation 1.3.21 and 2.0.3 or later. We strongly recommend upgrading to one of these versions.
The evaluation of EL expressions has been disabled by default now.
In order to use some interpolation in the violation messages added to `ViolationCollector`, it has to be explicitly allowed by setting `SelfValidating#escapeExpressions()` to `false`.
It is also recommended to use the `addViolation` methods supporting message parameters instead of EL expressions introduced in Dropwizard 1.3.21 and 2.0.3:
• `ViolationCollector#addViolation(String, Map`
• `ViolationCollector#addViolation(String, String, Map`
• `ViolationCollector#addViolation(String, String, Integer, Map`
• `ViolationCollector#addViolation(String, String, String, Map`
Workarounds
If you are not able to upgrade to one of the aforementioned versions of dropwizard-validation but still want to use the `@SelfValidating` feature, make sure to properly sanitize any message you're adding to the `ViolationCollector` in the method annotated with `@SelfValidation`.
Example:
```java
@SelfValidation
public void validateFullName(ViolationCollector col) {
if (fullName.contains("_")) {
// Sanitize fullName variable by escaping relevant characters such as "$"
col.addViolation("Full name contains invalid characters: " + sanitizeJavaEl(fullName));
}
}
```
See also:
https://github.com/dropwizard/dropwizard/blob/v2.0.3/dropwizard-validation/src/main/java/io/dropwizard/validation/InterpolationHelper.java
References
• https://github.com/dropwizard/dropwizard/security/advisories/GHSA-3mcp-9wr4-cjqf
• https://github.com/dropwizard/dropwizard/pull/3208
• https://github.com/dropwizard/dropwizard/pull/3209
• https://docs.jboss.org/hibernate/validator/6.1/reference/en-US/html_single/#section-hibernateconstraintvalidatorcontext
For more information
If you have any questions or comments about this advisory:
• Open an issue in dropwizard/dropwizard
• Start a discussion on the dropwizard-dev mailing list
Security contact
If you want to responsibly disclose a security issue in Dropwizard or one of its official modules, please contact us via the published channels in our security policy:
https://github.com/dropwizard/dropwizard/security/policy#reporting-a-vulnerability
Related
Alias · CVE (1)
- CVE-2020-11002 dropwizard-validation before versions 2.0.3 and 1.3.21 has a remote code execution vulnerability. vulnerability
Weakness · CWE (1)
- CWE-74 Improper Neutralization of Special Elements in Output Used by a Downstream Component weakness
References
- https://github.com/dropwizard/dropwizard/security/advisories/GHSA-3mcp-9wr4-cjqf web
- https://github.com/dropwizard/dropwizard/security/advisories/GHSA-8jpx-m2wh-2v34 web
- https://nvd.nist.gov/vuln/detail/CVE-2020-11002 advisory
- https://github.com/dropwizard/dropwizard/pull/3208 web
- https://github.com/dropwizard/dropwizard/pull/3209 web
- https://github.com/dropwizard/dropwizard/commit/d5a512f7abf965275f2a6b913ac4fe778e424242 web
- https://docs.jboss.org/hibernate/validator/6.1/reference/en-US/html_single/#section-hibernateconstraintvalidatorcontext web
- https://github.com/dropwizard/dropwizard/security/policy#reporting-a-vulnerability web