GitHub Advisoryadvisory · npm
GHSA-9wv6-86v2-598j path-to-regexp outputs backtracking regular expressions
HIGH
Official page ↗
- Aliases
- CVE-2024-45296
- Ecosystem
- npm
- Packages
- path-to-regexp
- Severity
- High
- CVSS vector
- CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:H
- Weaknesses
- CWE-1333
- Reviewed
- 2024-09-09
Affected packages
• npm path-to-regexp: >= 0.2.0, < 1.9.0 → fixed in 1.9.0
• npm path-to-regexp: < 0.1.10 → fixed in 0.1.10
• npm path-to-regexp: >= 7.0.0, < 8.0.0 → fixed in 8.0.0
• npm path-to-regexp: >= 2.0.0, < 3.3.0 → fixed in 3.3.0
• npm path-to-regexp: >= 4.0.0, < 6.3.0 → fixed in 6.3.0
Description
Impact
A bad regular expression is generated any time you have two parameters within a single segment, separated by something that is not a period (`.`). For example, `/:a-:b`.
Patches
For users of 0.1, upgrade to `0.1.10`. All other users should upgrade to `8.0.0`.
These versions add backtrack protection when a custom regex pattern is not provided:
• 0.1.10
• 1.9.0
• 3.3.0
• 6.3.0
They do not protect against vulnerable user supplied capture groups. Protecting against explicit user patterns is out of scope for old versions and not considered a vulnerability.
Version 7.1.0 can enable `strict: true` and get an error when the regular expression might be bad.
Version 8.0.0 removes the features that can cause a ReDoS.
Workarounds
All versions can be patched by providing a custom regular expression for parameters after the first in a single segment. As long as the custom regular expression does not match the text before the parameter, you will be safe. For example, change `/:a-:b` to `/:a-:b([^-/]+)`.
If paths cannot be rewritten and versions cannot be upgraded, another alternative is to limit the URL length. For example, halving the attack string improves performance by 4x faster.
Details
Using `/:a-:b` will produce the regular expression `/^\/([^\/]+?)-([^\/]+?)\/?$/`. This can be exploited by a path such as `/a${'-a'.repeat(8_000)}/a`. OWASP has a good example of why this occurs, but the TL;DR is the `/a` at the end ensures this route would never match but due to naive backtracking it will still attempt every combination of the `:a-:b` on the repeated 8,000 `-a`.
Because JavaScript is single threaded and regex matching runs on the main thread, poor performance will block the event loop and can lead to a DoS. In local benchmarks, exploiting the unsafe regex will result in performance that is over 1000x worse than the safe regex. In a more realistic environment using Express v4 and 10 concurrent connections, this translated to average latency of ~600ms vs 1ms.
References
• OWASP
• Detailed blog post
Related
Alias · CVE (1)
- CVE-2024-45296 path-to-regexp turns path strings into a regular expressions. vulnerability
Weakness · CWE (1)
- CWE-1333 Inefficient Regular Expression Complexity weakness
References
- https://github.com/pillarjs/path-to-regexp/security/advisories/GHSA-9wv6-86v2-598j web
- https://nvd.nist.gov/vuln/detail/CVE-2024-45296 advisory
- https://github.com/pillarjs/path-to-regexp/commit/29b96b4a1de52824e1ca0f49a701183cc4ed476f web
- https://github.com/pillarjs/path-to-regexp/commit/60f2121e9b66b7b622cc01080df0aabda9eedee6 web
- https://github.com/pillarjs/path-to-regexp/commit/925ac8e3c5780b02f58cbd4e52f95da8ad2ac485 web
- https://github.com/pillarjs/path-to-regexp/commit/d31670ae8f6e69cbfd56e835742195b7d10942ef web
- https://github.com/pillarjs/path-to-regexp/commit/f1253b47b347dcb909e3e80b0eb2649109e59894 web
- https://github.com/pillarjs/path-to-regexp package
- https://github.com/pillarjs/path-to-regexp/releases/tag/v6.3.0 web
- https://security.netapp.com/advisory/ntap-20250124-0001 web