GitHub Advisoryadvisory · PyPI
GHSA-c5x2-p679-95wc Null pointer dereference in `SparseTensorSliceDataset`
HIGH
Official page ↗
- Aliases
- CVE-2021-37647
- Ecosystem
- PyPI
- Packages
- tensorflow, tensorflow-cpu, tensorflow-gpu
- Severity
- High
- CVSS vector
- CVSS:3.1/AV:L/AC:L/PR:N/UI:N/S:U/C:N/I:H/A:H
- Weaknesses
- CWE-476
- Reviewed
- 2021-08-23
Affected packages
• PyPI tensorflow: < 2.3.4 → fixed in 2.3.4
• PyPI tensorflow: >= 2.4.0, < 2.4.3 → fixed in 2.4.3
• PyPI tensorflow: >= 2.5.0, < 2.5.1 → fixed in 2.5.1
• PyPI tensorflow-cpu: < 2.3.4 → fixed in 2.3.4
• PyPI tensorflow-cpu: >= 2.4.0, < 2.4.3 → fixed in 2.4.3
• PyPI tensorflow-cpu: >= 2.5.0, < 2.5.1 → fixed in 2.5.1
• PyPI tensorflow-gpu: < 2.3.4 → fixed in 2.3.4
• PyPI tensorflow-gpu: >= 2.4.0, < 2.4.3 → fixed in 2.4.3
• PyPI tensorflow-gpu: >= 2.5.0, < 2.5.1 → fixed in 2.5.1
Description
Impact
When a user does not supply arguments that determine a valid sparse tensor, `tf.raw_ops.SparseTensorSliceDataset` implementation can be made to dereference a null pointer:
```python
import tensorflow as tf
tf.raw_ops.SparseTensorSliceDataset(
indices=[[],[],[]],
values=[1,2,3],
dense_shape=[3,3])
```
The implementation has some argument validation but fails to consider the case when either `indices` or `values` are provided for an empty sparse tensor when the other is not.
If `indices` is empty (as in the example above), then code that performs validation (i.e., checking that the indices are monotonically increasing) results in a null pointer dereference:
```cc
for (int64_t i = 0; i dim_size(0); ++i) {
int64_t next_batch_index = indices->matrix()(i, 0);
...
}
```
If `indices` as provided by the user is empty, then `indices` in the C++ code above is backed by an empty `std::vector`, hence calling `indices->dim_size(0)` results in null pointer dereferencing (same as calling `std::vector::at()` on an empty vector).
Patches
We have patched the issue in GitHub commit 02cc160e29d20631de3859c6653184e3f876b9d7.
The fix will be included in TensorFlow 2.6.0. We will also cherrypick this commit on TensorFlow 2.5.1, TensorFlow 2.4.3, and TensorFlow 2.3.4, as these are also affected and still in supported range.
For more information
Please consult our security guide for more information regarding the security model and how to contact us with issues and questions.
Attribution
This vulnerability has been reported by members of the Aivul Team from Qihoo 360.
Related
Alias · CVE (1)
- CVE-2021-37647 TensorFlow is an end-to-end open source platform for machine learning. vulnerability
Weakness · CWE (1)
- CWE-476 NULL Pointer Dereference weakness
References
- https://github.com/tensorflow/tensorflow/security/advisories/GHSA-c5x2-p679-95wc web
- https://nvd.nist.gov/vuln/detail/CVE-2021-37647 advisory
- https://github.com/tensorflow/tensorflow/commit/02cc160e29d20631de3859c6653184e3f876b9d7 web
- https://github.com/pypa/advisory-database/tree/main/vulns/tensorflow-cpu/PYSEC-2021-560.yaml web
- https://github.com/pypa/advisory-database/tree/main/vulns/tensorflow-gpu/PYSEC-2021-758.yaml web
- https://github.com/pypa/advisory-database/tree/main/vulns/tensorflow/PYSEC-2021-269.yaml web
- https://github.com/tensorflow/tensorflow package