GitHub Advisoryadvisory · crates.io

GHSA-cgw6-f3mj-h742 RustEmbed generated `get` method allows for directory traversal when reading files from disk

MEDIUM Published 2022-06-17 Modified 2022-06-17 Official page ↗
Ecosystem
crates.io
Packages
rust-embed
Severity
Moderate
Weaknesses
CWE-22
Reviewed
2022-06-17

Affected packages

• crates.io rust-embed: < 6.3.0 → fixed in 6.3.0

Description

When running in debug mode and the `debug-embed` (off by default) feature is not enabled, the generated `get` method does not check that the input path is a child of the folder given. This allows attackers to read arbitrary files in the file system if they have control over the filename given. The following code will print the contents of your `/etc/passwd` if adjusted with a correct number of `../`s depending on where it is run from. ```rust [derive(rust_embed::RustEmbed)] [folder = "src/"] pub struct Asset; fn main() { let d = Asset::get("../../../etc/passwd").unwrap().data; println!("{}", String::from_utf8_lossy(&d)); } ``` The flaw was corrected by canonicalizing the input filename and ensuring that it starts with the canonicalized folder path.

Related

Weakness · CWE (1)

  • CWE-22 Improper Limitation of a Pathname to a Restricted Directory weakness

References