GitHub Advisoryadvisory · crates.io
GHSA-fcmm-54jp-7vf6 Frontier's modexp precompile is slow for even modulus
HIGH
Official page ↗
- Aliases
- CVE-2023-28431
- Ecosystem
- crates.io
- Packages
- pallet-evm-precompile-modexp
- Severity
- High
- CVSS vector
- CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:H
- Weaknesses
- CWE-682
- Reviewed
- 2023-03-21
Affected packages
• crates.io pallet-evm-precompile-modexp: <= 1.0.0 (no fix yet)
Description
Impact
Frontier's `modexp` precompile uses `num-bigint` crate under the hood. In the implementation, the cases for modulus being even and modulus being odd are treated separately. Odd modulus uses the fast Montgomery multiplication, and even modulus uses the slow plain power algorithm. This gas cost discrepancy was not accounted for in the `modexp` precompile, leading to possible denial of service attacks.
Patches
No fixes for `num-bigint` is currently available, and thus this advisory will be first fixed in the short term by raising the gas costs for even modulus, and in the long term fixing it in `num-bigint` or switching to another modexp implementation.
The short-term fix for Frontier is deployed at PR 1017.
The recommendations are as follows:
• If you anticipate malicious validators, it's recommended to issue an emergency runtime upgrade as soon as possible.
• If you do not anticipate malicious validators, it's recommended to issue a normal runtime upgrade, as Substrate has builtin timeout protection when validators are building blocks.
Workarounds
None.
References
A similar issue was presented in Geth's implementation and the fix can be found here.
Related
Alias · CVE (1)
- CVE-2023-28431 Frontier is an Ethereum compatibility layer for Substrate. vulnerability
Weakness · CWE (1)
- CWE-682 Incorrect Calculation weakness
References
- https://github.com/paritytech/frontier/security/advisories/GHSA-fcmm-54jp-7vf6 web
- https://nvd.nist.gov/vuln/detail/CVE-2023-28431 advisory
- https://github.com/paritytech/frontier/pull/1017 web
- https://github.com/paritytech/frontier/commit/5af12e94d7dfc8a0208a290643a800f55de7b219 web
- https://github.com/polkadot-evm/frontier package
- https://github.com/rust-num/num-bigint/blob/6f2b8e0fc218dbd0f49bebb8db2d1a771fe6bafa/src/biguint/power.rs#L134 web