GitHub Advisoryadvisory · npm
GHSA-fr3w-2p22-6w7p URL Redirection to Untrusted Site in OAuth2/OpenID in directus
MEDIUM
Official page ↗
- Aliases
- CVE-2024-28239
- Ecosystem
- npm
- Packages
- directus
- Severity
- Moderate
- CVSS vector
- CVSS:3.1/AV:N/AC:L/PR:N/UI:R/S:U/C:L/I:L/A:N
- Weaknesses
- CWE-601
- Reviewed
- 2024-03-12
Affected packages
• npm directus: < 10.10.0 → fixed in 10.10.0
Description
Summary
The authentication API has a `redirect` parameter that can be exploited as an open redirect vulnerability as the user tries to log in via the API URL https://docs.directus.io/reference/authentication.html#login-using-sso-providers /auth/login/google?redirect for example.
Details
There's a redirect that is done after successful login via the Auth API GET request to `directus/auth/login/google?redirect=http://malicious-fishing-site.com`, which I think is here: https://github.com/directus/directus/blob/main/api/src/auth/drivers/oauth2.ts#L394. While credentials don't seem to be passed to the attacker site, the user can be phished into clicking a legitimate directus site and be taken to a malicious site made to look like a an error message "Your password needs to be updated" to phish out the current password.
PoC
Turn on any auth provider in Directus instance. Form a link to `directus-instance/auth/login/:provider_id?redirect=http://malicious-fishing-site.com`, login and get taken to malicious-site. Tested on the `ory` OAuth2 integration.
Impact
Users who login via OAuth2 into Directus.
Related
Alias · CVE (1)
- CVE-2024-28239 Directus is a real-time API and App dashboard for managing SQL database content. vulnerability
Weakness · CWE (1)
- CWE-601 URL Redirection to Untrusted Site weakness
References
- https://github.com/directus/directus/security/advisories/GHSA-fr3w-2p22-6w7p web
- https://nvd.nist.gov/vuln/detail/CVE-2024-28239 advisory
- https://github.com/directus/directus/commit/5477d7d61babd7ffc2f835d399bf79611b15b203 web
- https://docs.directus.io/reference/authentication.html#login-using-sso-providers web
- https://github.com/directus/directus package