GitHub Advisoryadvisory · crates.io

GHSA-gw5w-5j7f-jmjj Unsound usages of `std::slice::from_raw_parts`

LOW Published 2024-12-05 Modified 2024-12-05 Official page ↗
Ecosystem
crates.io
Packages
pprof
Severity
Low
Reviewed
2024-12-05

Affected packages

• crates.io pprof: < 0.14.0 → fixed in 0.14.0

Description

The library breaks the safety assumptions when using unsafe API `std::slice::from_raw_parts`. First, when using the API in iterator implementation (`TempFdArrayIterator.next`), generic type could be any type, which would create and pass a misaligned pointer to the unsafe API. Second, when validating the address, the code passed the type `c_void`, which could also be any type, leading to potential uninitialized memory exposure. Two unsound usages here highlight the necessity for developers to perform type checks before doing type conversion with unsafe API. The panic caused by the misalignment causes several downstream applications (e.g., `greptimedb`) to crash when using `pprof::report::ReportBuilder::build`. This was patched in 0.14.0. The developer also suggested moving to pprof2.

References