GitHub Advisoryadvisory · Maven
GHSA-gwxv-jv83-6qjr JStachio XSS vulnerability: Unescaped single quotes
MEDIUM
Official page ↗
- Aliases
- CVE-2023-33962
- Ecosystem
- Maven
- Packages
- io.jstach:jstachio
- Severity
- Moderate
- CVSS vector
- CVSS:3.1/AV:N/AC:L/PR:L/UI:R/S:C/C:L/I:L/A:N
- Weaknesses
- CWE-79
- Reviewed
- 2023-06-06
Affected packages
• Maven io.jstach:jstachio: < 1.0.1 → fixed in 1.0.1
Description
Impact
Description:
JStachio fails to escape single quotes `'` in HTML, allowing an attacker to inject malicious code.
Reproduction Steps:
Use the following template code:
```html
```
Set the value variable to `' onblur='alert(1)`.
```java
public class Escaping {
public static void main(String[] args) {
Model model = new Model("' onblur='alert(1)");
String result = AttributeTemplate.of().execute(model);
System.out.println(result);
}
@JStache(template = "",
name="AttributeTemplate")
@JStacheConfig(contentType= Html.class)
public static class Model {
public final String value;
public Model(String value) {
this.value = value;
}
public String getValue() {
return value;
}
}
}
```
Expected Result:
The resulting output should have properly escaped the single quotes and not execute the injected JavaScript code.
Actual Result:
The resulting output is vulnerable and renders as follows:
```html
```
Impact and Risk:
This vulnerability can be exploited by an attacker to execute arbitrary JavaScript code in the context of other users visiting pages that use this template engine. This can lead to various consequences, including session hijacking, defacement of web pages, theft of sensitive information, or even the propagation of malware.
Proposed Solution:
To mitigate this vulnerability, the template engine should properly escape special characters, including single quotes. Common practice is to escape `'` as `'`.
Patches
-
Workarounds
As long as users stick with double quotes `"` for HTML attributes, they should not be affected.
References
For instance, Rocker's general purpose HTML escaping
Related
Alias · CVE (1)
- CVE-2023-33962 JStachio is a type-safe Java Mustache templating engine. vulnerability
Weakness · CWE (1)
- CWE-79 Improper Neutralization of Input During Web Page Generation weakness
References
- https://github.com/jstachio/jstachio/security/advisories/GHSA-gwxv-jv83-6qjr web
- https://nvd.nist.gov/vuln/detail/CVE-2023-33962 advisory
- https://github.com/jstachio/jstachio/issues/157 web
- https://github.com/jstachio/jstachio/pull/158 web
- https://github.com/jstachio/jstachio/commit/7b2f78377d1284df14c580be762a25af5f8dcd66 web
- https://github.com/jstachio/jstachio package
- https://github.com/jstachio/jstachio/releases/tag/v1.0.1 web