GitHub Advisoryadvisory · Packagist
GHSA-h6m7-j4h3-9rf5 Remote Code Execution in SyliusResourceBundle
CRITICAL
Official page ↗
- Aliases
- CVE-2020-15146
- Ecosystem
- Packagist
- Packages
- sylius/resource-bundle
- Severity
- Critical
- CVSS vector
- CVSS:3.1/AV:N/AC:L/PR:L/UI:N/S:C/C:H/I:H/A:N
- Weaknesses
- CWE-74, CWE-917
- Reviewed
- 2020-08-19
Affected packages
• Packagist sylius/resource-bundle: >= 1.4.0, < 1.4.7 → fixed in 1.4.7
• Packagist sylius/resource-bundle: >= 1.5.0, < 1.5.2 → fixed in 1.5.2
• Packagist sylius/resource-bundle: >= 1.6.0, < 1.6.4 → fixed in 1.6.4
• Packagist sylius/resource-bundle: >= 1.0.0, < 1.3.14 → fixed in 1.3.14
Description
Impact
Request parameters injected inside an expression evaluated by `symfony/expression-language` package haven't been sanitized properly. This allows the attacker to access any public service by manipulating that request parameter, allowing for Remote Code Execution.
The vulnerable versions include: `=1.4.0 =1.5.0 =1.6.0 <=1.6.3`.
Example
```yaml
sylius_grid:
grids:
foo:
fields:
bar:
options:
baz: "expr:service('sylius.repository.product').find($id)"
```
In this case, `$id` can be prepared in a way that calls other services.
If you visit `/route?id="~service('doctrine').getManager().getConnection().executeQuery("DELETE * FROM TABLE")~"`, it will result in a following expression `expr:service('repository').find(""~service('doctrine').getManager().getConnection().executeQuery("DELETE * FROM TABLE")~"")`, which will execute a query on the currently connected database.
To find a vulnerability in your application, look for any routing definition that uses request parameters inside expression language.
Patches
This issue has been patched for versions 1.3.14, 1.4.7, 1.5.2 and 1.6.4. Versions prior to 1.3 were not patched.
Workarounds
The fix requires adding `addslashes` in `OptionsParser::parseOptionExpression` to sanitize user input before evaluating it using the expression language.
```php
• return is_string($variable) ? sprintf('"%s"', $variable) : $variable;
+ return is_string($variable) ? sprintf('"%s"', addslashes($variable)) : $variable;
```
Acknowledgements
This security issue has been reported by Craig Blanchette (@isometriks), thanks a lot!
For more information
If you have any questions or comments about this advisory:
• Email us at [email protected]
Related
Alias · CVE (1)
- CVE-2020-15146 In SyliusResourceBundle before versions 1.3.14, 1.4.7, 1.5.2 and 1.6.4, request parameters injected inside an expression evaluated by… vulnerability
References
- https://github.com/Sylius/SyliusResourceBundle/security/advisories/GHSA-h6m7-j4h3-9rf5 web
- https://nvd.nist.gov/vuln/detail/CVE-2020-15146 advisory
- https://github.com/Sylius/SyliusResourceBundle/commit/73d9aba182947473a5935b31caf65ca263091e00 web
- https://github.com/FriendsOfPHP/security-advisories/blob/master/sylius/resource-bundle/CVE-2020-15146.yaml web
- https://github.com/Sylius/SyliusResourceBundle package