GitHub Advisoryadvisory · Maven

GHSA-hf43-47q4-fhq5 XWiki Commons missing escaping of `{` in Velocity escapetool allows remote code execution

CRITICAL Published 2024-04-10 Modified 2024-04-10 Official page ↗
Aliases
CVE-2024-31996
Ecosystem
Maven
Packages
org.xwiki.commons:xwiki-commons-velocity
Severity
Critical
CVSS vector
CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:C/C:H/I:H/A:H
Weaknesses
CWE-94, CWE-95
Reviewed
2024-04-10

Affected packages

• Maven org.xwiki.commons:xwiki-commons-velocity: >= 3.0.1, < 14.10.19 → fixed in 14.10.19 • Maven org.xwiki.commons:xwiki-commons-velocity: >= 15.0-rc-1, < 15.5.4 → fixed in 15.5.4 • Maven org.xwiki.commons:xwiki-commons-velocity: >= 15.6-rc-1, < 15.9-rc-1 → fixed in 15.9-rc-1

Description

Impact The HTML escaping of escaping tool that is used in XWiki doesn't escape `{`, which, when used in certain places, allows XWiki syntax injection and thereby remote code execution. To reproduce in an XWiki installation, open `/xwiki/bin/view/Panels/PanelLayoutUpdate?place=%7B%7B%2Fhtml%7D%7D%7B%7Basync%20async%3Dfalse%7D%7D%7B%7Bvelocity%7D%7D%23evaluate(%24request.eval)%7B%7B%2Fvelocity%7D%7D%7B%7B%2Fasync%7D%7D&eval=Hello%20from%20URL%20Parameter!%20I%20got%20programming%3A%20%24services.security.authorization.hasAccess(%27programming%27)` where `` is the URL of your XWiki installation. If this displays `You are not admin on this place Hello from URL Parameter! I got programming: true`, the installation is vulnerable. Patches The vulnerability has been fixed on XWiki 14.10.19, 15.5.5, and 15.9 RC1. Workarounds Apart from upgrading, there is no generic workaround. However, replacing `$escapetool.html` by `$escapetool.xml` in XWiki documents fixes the vulnerability. In a standard XWiki installation, we're only aware of the document `Panels.PanelLayoutUpdate` that exposes this vulnerability, patching this document is thus a workaround. Any extension could expose this vulnerability and might thus require patching, too. References • https://github.com/xwiki/xwiki-commons/commit/b94142e2a66ec32e89eacab67c3da8d91f5ef93a • https://jira.xwiki.org/browse/XCOMMONS-2828 • https://jira.xwiki.org/browse/XWIKI-21438

Related

Alias · CVE (1)

  • CVE-2024-31996 XWiki Platform is a generic wiki platform. vulnerability

Weakness · CWE (2)

  • CWE-94 Improper Control of Generation of Code weakness
  • CWE-95 Improper Neutralization of Directives in Dynamically Evaluated Code weakness

References