GitHub Advisoryadvisory · RubyGems
GHSA-q28m-8xjw-8vr5 Puma's Keepalive Connections Causing Denial Of Service
HIGH
Official page ↗
- Aliases
- CVE-2021-29509
- Ecosystem
- RubyGems
- Packages
- puma
- Severity
- High
- CVSS vector
- CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:H
- Weaknesses
- CWE-400
- Reviewed
- 2021-05-18
Affected packages
• RubyGems puma: < 4.3.8 → fixed in 4.3.8
• RubyGems puma: >= 5.0.0, < 5.3.1 → fixed in 5.3.1
Description
This vulnerability is related to CVE-2019-16770.
Impact
The fix for CVE-2019-16770 was incomplete. The original fix only protected existing connections that had already been accepted from having their requests starved by greedy persistent-connections saturating all threads in the same process. However, new connections may still be starved by greedy persistent-connections saturating all threads in all processes in the cluster.
A `puma` server which received more concurrent `keep-alive` connections than the server had threads in its threadpool would service only a subset of connections, denying service to the unserved connections.
Patches
This problem has been fixed in `puma` 4.3.8 and 5.3.1.
Workarounds
Setting `queue_requests false` also fixes the issue. This is not advised when using `puma` without a reverse proxy, such as `nginx` or `apache`, because you will open yourself to slow client attacks (e.g. slowloris)).
The fix is very small. A git patch is available here for those using unsupported versions of Puma.
For more information
If you have any questions or comments about this advisory:
• Open an issue in Puma.
• To report problems with this fix or to report another vulnerability, see our security policy.
Acknowledgements
Thank you to @MSP-Greg, @wjordan and @evanphx for their review on this issue.
Thank you to @ioquatix for providing a modified fork of `wrk` which made debugging this issue much easier.
Related
Alias · CVE (1)
- CVE-2021-29509 Puma is a concurrent HTTP 1.1 server for Ruby/Rack applications. vulnerability
Weakness · CWE (1)
- CWE-400 Uncontrolled Resource Consumption weakness
References
- https://github.com/puma/puma/security/advisories/GHSA-q28m-8xjw-8vr5 web
- https://nvd.nist.gov/vuln/detail/CVE-2021-29509 advisory
- https://gist.github.com/nateberkopec/4b3ea5676c0d70cbb37c82d54be25837 web
- https://github.com/puma/puma package
- https://github.com/puma/puma/security/policy web
- https://github.com/rubysec/ruby-advisory-db/blob/master/gems/puma/CVE-2021-29509.yml web
- https://lists.debian.org/debian-lts-announce/2022/08/msg00015.html web
- https://rubygems.org/gems/puma web
- https://security.gentoo.org/glsa/202208-28 web