GitHub Advisoryadvisory · PyPI

GHSA-q6j3-c4wc-63vw CSRF tokens leaked in URL by canned query form

MEDIUM Published 2020-08-11 Modified 2021-09-23 Official page ↗
Ecosystem
PyPI
Packages
datasette
Severity
Moderate
CVSS vector
CVSS:3.1/AV:N/AC:L/PR:N/UI:R/S:U/C:L/I:N/A:N
Weaknesses
CWE-200
Reviewed
2020-08-10

Affected packages

• PyPI datasette: < 0.46 → fixed in 0.46

Description

Impact The HTML form for a read-only canned query includes the hidden CSRF token field added in #798 for writable canned queries (#698). This means that submitting those read-only forms exposes the CSRF token in the URL - for example on https://latest.datasette.io/fixtures/neighborhood_search submitting the form took me to: https://latest.datasette.io/fixtures/neighborhood_search?text=down&csrftoken=CSRFTOKEN-HERE This token could potentially leak to an attacker if the resulting page has a link to an external site on it and the user clicks the link, since the token would be exposed in the referral logs. Patches A fix for this issue has been released in Datasette 0.46. Workarounds You can fix this issue in a Datasette instance without upgrading by copying the 0.46 query.html template into a custom `templates/` directory and running Datasette with the `--template-dir=templates/` option. References Issue 918 discusses this in details: https://github.com/simonw/datasette/issues/918 For more information Contact swillison at gmail with any questions.

Related

Weakness · CWE (1)

  • CWE-200 Exposure of Sensitive Information to an Unauthorized Actor weakness

References