GitHub Advisoryadvisory · npm, RubyGems
GHSA-qjqp-xr96-cj99 Trix Editor Arbitrary Code Execution Vulnerability
MEDIUM
Official page ↗
- Aliases
- CVE-2024-34341
- Ecosystem
- npm, RubyGems
- Packages
- trix, actiontext
- Severity
- Moderate
- CVSS vector
- CVSS:3.1/AV:N/AC:L/PR:N/UI:R/S:U/C:L/I:L/A:N
- Weaknesses
- CWE-79
- Reviewed
- 2024-05-07
Affected packages
• npm trix: >= 2.0.0, < 2.1.1 → fixed in 2.1.1
• npm trix: >= 0.9.0, < 1.3.2 → fixed in 1.3.2
• RubyGems actiontext: >= 7.0.0.alpha1, < 7.0.8.3 → fixed in 7.0.8.3
• RubyGems actiontext: >= 7.1.0.beta1, < 7.1.3.3 → fixed in 7.1.3.3
Description
The Trix editor, versions prior to 2.1.1, is vulnerable to arbitrary code execution when copying and pasting content from the web or other documents with markup into the editor. The vulnerability stems from improper sanitization of pasted content, allowing an attacker to embed malicious scripts which are executed within the context of the application.
Vulnerable Versions:
• 1.x series up to and including 1.3.1
• 2.x series up to and including 2.1.0
Fixed Versions:
• v1.3.2
• v2.1.1
Vector:
• Bug 1: When copying content manipulated by a script, such as:
```js
document.addEventListener('copy', function(e){
e.clipboardData.setData('text/html', '456');
e.preventDefault();
});
```
and pasting into the Trix editor, the script within the content is executed.
• Bug 2: Similar execution occurs with content structured as:
```js
document.write(`copyme`);
```
Impact:
An attacker could exploit these vulnerabilities to execute arbitrary JavaScript code within the context of the user's session, potentially leading to unauthorized actions being performed or sensitive information being disclosed.
Remediation:
Update Recommendation: Users should upgrade to Trix editor version 2.1.1 or later, which incorporates proper sanitization of input from copied content.
CSP Enhancement: Additionally, enhancing the Content Security Policy (CSP) to disallow inline scripts can significantly mitigate the risk of such vulnerabilities. Set CSP policies such as script-src 'self' to ensure that only scripts hosted on the same origin are executed, and explicitly prohibit inline scripts using script-src-elem.
References:
• https://github.com/basecamp/trix/releases/tag/v2.1.1
• https://github.com/basecamp/trix/pull/1147
• https://github.com/basecamp/trix/pull/1149
• https://github.com/basecamp/trix/pull/1153
Credit: These issues were reported by security researchers loknop and pinpie.
Related
Alias · CVE (1)
- CVE-2024-34341 Trix is a rich text editor. vulnerability
Weakness · CWE (1)
- CWE-79 Improper Neutralization of Input During Web Page Generation weakness
References
- https://github.com/basecamp/trix/security/advisories/GHSA-qjqp-xr96-cj99 web
- https://nvd.nist.gov/vuln/detail/CVE-2024-34341 advisory
- https://github.com/basecamp/trix/pull/1147 web
- https://github.com/basecamp/trix/pull/1149 web
- https://github.com/basecamp/trix/commit/1a5c68a14d48421fc368e30026f4a7918028b7ad web
- https://github.com/basecamp/trix/commit/841ff19b53f349915100bca8fcb488214ff93554 web
- https://github.com/rails/rails/commit/07e6c88cc4defe6f6b8d28e79eb13a518e15b14c web
- https://github.com/rails/rails/commit/260cb392fc1ee91d0b749cff08d1c8d54b230bd3 web
- https://github.com/rails/rails/commit/73fac32511eefdd45d8f00fecc2b8cc5408ea6d5 web
- https://discuss.rubyonrails.org/t/xss-vulnerabilities-in-trix-editor/85803 web
- https://github.com/basecamp/trix package
- https://github.com/basecamp/trix/releases/tag/v2.1.1 web
- https://github.com/rubysec/ruby-advisory-db/blob/master/gems/actiontext/CVE-2024-34341.yml web
- https://rubyonrails.org/2024/5/17/Rails-Versions-7-0-8-2-and-7-1-3-3-have-been-released web
- https://rubyonrails.org/2024/5/17/Rails-Versions-7-0-8-3-has-been-released web