GHSA-v2f9-rv6w-vw8r Sylius potentially vulnerable to Cross Site Scripting via "Name" field (Taxons, Products, Options, Variants) in Admin Panel

• Packagist sylius/sylius: < 1.9.12 → fixed in 1.9.12 • Packagist sylius/sylius: >= 1.10.0-alpha.1, < 1.10.16 → fixed in 1.10.16 • Packagist sylius/sylius: >= 1.11.0-alpha.1, < 1.11.17 → fixed in 1.11.17 • Packagist sylius/sylius: >= 1.12.0-alpha.1, < 1.12.16 → fixed in 1.12.16 • Packagist sylius/sylius: >= 1.13.0-alpha.1, < 1.13.1 → fixed in 1.13.1

Impact There is a possibility to execute javascript code in the Admin panel. In order to perform an XSS attack input a script into `Name` field in which of the resources: Taxons, Products, Product Options or Product Variants. The code will be executed while using an autocomplete field with one of the listed entities in the Admin Panel. Also for the taxons in the category tree on the product form. Patches The issue is fixed in versions: 1.9.12, 1.10.16, 1.11.17, 1.12.16, 1.13.1 and above. Workarounds 1. Create a new file `assets/admin/sylius-lazy-choice-tree.js`: ```js // assets/admin/sylius-lazy-choice-tree.js function sanitizeInput(input) { const div = document.createElement('div'); div.textContent = input; return div.innerHTML; // Converts text content to plain HTML, stripping any scripts } const createRootContainer = function createRootContainer() { return $(''); }; const createLeafContainerElement = function createLeafContainerElement() { return $(''); }; const createLeafIconElement = function createLeafIconElement() { return $(''); }; const createLeafTitleElement = function createLeafTitleElement() { return $(''); }; const createLeafTitleSpan = function createLeafTitleSpan(displayName) { return $(`${displayName}`); }; const createLeafContentElement = function createLeafContentElement() { return $(''); }; $.fn.extend({ choiceTree(type, multiple, defaultLevel) { const tree = this; const loader = tree.find('.dimmer'); const loadedLeafs = []; const $input = tree.find('input[type="hidden"]'); const createCheckboxElement = function createCheckboxElement(name, code, multi) { const chosenNodes = $input.val().split(','); let checked = ''; if (chosenNodes.some(chosenCode => chosenCode === code)) { checked = 'checked="checked"'; } if (multi) { return $(``); } return $(``); }; const isLeafLoaded = function isLeafLoaded(code) { return loadedLeafs.some(leafCode => leafCode === code); }; let createLeafFunc; const loadLeafAction = function loadLeafAction(parentCode, expandButton, content, icon, leafContainerElement) { icon.toggleClass('open'); if (!isLeafLoaded(parentCode)) { expandButton.api({ on: 'now', url: tree.data('tree-leafs-url') || tree.data('taxon-leafs-url'), method: 'GET', cache: false, data: { parentCode, }, beforeSend(settings) { loader.addClass('active'); return settings; }, onSuccess(response) { response.forEach((leafNode) => { leafContainerElement.append(( createLeafFunc(sanitizeInput(leafNode.name), leafNode.code, leafNode.hasChildren, multiple, leafNode.level) )); }); content.append(leafContainerElement); loader.removeClass('active'); loadedLeafs.push(parentCode); leafContainerElement.toggle(); }, }); } leafContainerElement.toggle(); }; const bindExpandLeafAction = function bindExpandLeafAction(parentCode, expandButton, content, icon, level) { const leafContainerElement = createLeafContainerElement(); if (defaultLevel > level) { loadLeafAction(parentCode, expandButton, content, icon, leafContainerElement); } expandButton.click(() => { loadLeafAction(parentCode, expandButton, content, icon, leafContainerElement); }); }; const bindCheckboxAction = function bindCheckboxAction(checkboxElement) { checkboxElement.checkbox({ onChecked() { const { value } = checkboxElement[0].dataset; const checkedValues = $input.val().split(',').filter(Boolean); checkedValues.push(value); $input.val(checkedValues.join()); }, onUnchecked() { const { value } = checkboxElement[0].dataset; const checkedValues = $input.val().split(',').filter(Boolean); const i = checkedValues.indexOf(value); if (i !== -1) { checkedValues.splice(i, 1); } $input.val(checkedValues.join()); }, }); }; const createLeaf = function createLeaf(name, code, hasChildren, multipleChoice, level) { const displayNameElement = createLeafTitleSpan(name); const titleElement = createLeafTitleElement(); const iconElement = createLeafIconElement(); const checkboxElement = createCheckboxElement(name, code, multipleChoice); bindCheckboxAction(checkboxElement); const leafElement = $(''); const leafContentElement = createLeafContentElement(); leafElement.append(iconElement); titleElement.append(displayNameElement); titleElement.append(checkboxElement); leafContentElement.append(titleElement); if (!hasChildren) { iconElement.addClass('outline'); } if (hasChildren) { bindExpandLeafAction(code, displayNameElement, leafContentElement, iconElement, level); } leafElement.append(leafContentElement); return leafElement; }; createLeafFunc = createLeaf; tree.api({ on: 'now', method: 'GET', url: tree.data('tree-root-nodes-url') || tree.data('taxon-root-nodes-url'), cache: false, beforeSend(settings) { loader.addClass('active'); return settings; }, onSuccess(response) { const rootContainer = createRootContainer(); response.forEach((rootNode) => { rootContainer.append(( createLeaf(sanitizeInput(rootNode.name), rootNode.code, rootNode.hasChildren, multiple, rootNode.level) )); }); tree.append(rootContainer); loader.removeClass('active'); }, }); }, }); ``` 2. Create new file `assets/admin/sylius-auto-complete.js`: ```js // assets/admin/sylius-auto-complete.js function sanitizeInput(input) { const div = document.createElement('div'); div.textContent = input; return div.innerHTML; // Converts text content to plain HTML, stripping any scripts } $.fn.extend({ autoComplete() { this.each((idx, el) => { const element = $(el); const criteriaName = element.data('criteria-name'); const choiceName = element.data('choice-name'); const choiceValue = element.data('choice-value'); const autocompleteValue = element.find('input.autocomplete').val(); const loadForEditUrl = element.data('load-edit-url'); element.dropdown({ delay: { search: 250, }, forceSelection: false, saveRemoteData: false, verbose: true, apiSettings: { dataType: 'JSON', cache: false, beforeSend(settings) { /* eslint-disable-next-line no-param-reassign */ settings.data[criteriaName] = settings.urlData.query; return settings; }, onResponse(response) { let results = response.map(item => ({ name: sanitizeInput(item[choiceName]), value: sanitizeInput(item[choiceValue]), })); if (!element.hasClass('multiple')) { results.unshift({ name: '&nbsp;', value: '', }); } return { success: true, results: results, }; }, }, }); if (autoco…