GitHub Advisoryadvisory · PyPI
GHSA-v936-j8gp-9q3p Open redirects on some federation and push requests
MEDIUM
Official page ↗
- Aliases
- CVE-2021-21273
- Ecosystem
- PyPI
- Packages
- matrix-synapse
- Severity
- Moderate
- CVSS vector
- CVSS:3.1/AV:N/AC:H/PR:N/UI:R/S:U/C:N/I:L/A:N
- Weaknesses
- CWE-601
- Reviewed
- 2021-02-26
Affected packages
• PyPI matrix-synapse: < 1.25.0 → fixed in 1.25.0
Description
Impact
Requests to user provided domains were not restricted to external IP addresses when calculating the key validity for third-party invite events and sending push notifications. This could cause Synapse to make requests to internal infrastructure. The type of request was not controlled by the user, although limited modification of request bodies was possible.
For the most thorough protection server administrators should remove the deprecated `federation_ip_range_blacklist` from their settings after upgrading to Synapse v1.25.0 which will result in Synapse using the improved default IP address restrictions. See the new `ip_range_blacklist` and `ip_range_whitelist` settings if more specific control is necessary.
Patches
Issue is resolved by #8821. Further improvements to protect homeservers by default were made in #8870 and #8954.
Workarounds
Requests to internal IP addresses could be blocked at the system or network level.
Related
Alias · CVE (1)
- CVE-2021-21273 Synapse is a Matrix reference homeserver written in python (pypi package matrix-synapse). vulnerability
Weakness · CWE (1)
- CWE-601 URL Redirection to Untrusted Site weakness
References
- https://github.com/matrix-org/synapse/security/advisories/GHSA-v936-j8gp-9q3p web
- https://nvd.nist.gov/vuln/detail/CVE-2021-21273 advisory
- https://github.com/matrix-org/synapse/pull/8821 web
- https://github.com/matrix-org/synapse/commit/30fba6210834a4ecd91badf0c8f3eb278b72e746 web
- https://github.com/matrix-org/synapse package
- https://github.com/matrix-org/synapse/releases/tag/v1.25.0 web
- https://github.com/pypa/advisory-database/tree/main/vulns/matrix-synapse/PYSEC-2021-131.yaml web
- https://lists.fedoraproject.org/archives/list/[email protected]/message/TNNAJOZNMVMXM6AS7RFFKB4QLUJ4IFEY web