GHSA-w4h6-9wrp-v5jq Malicious Long Unicode filenames may cause a Multiple Application-level Denial of Service

• PyPI frigate: < 0.13.2 → fixed in 0.13.2

Important: Exploiting this vulnerability requires the attacker to have access to your Frigate instance, which means they could also just delete all of your recordings or perform any other action. If you have configured authentication in front of Frigate via a reverse proxy, then this vulnerability is not exploitable without first getting around your authentication method. For many obvious reasons in addition to this one, please don't expose your Frigate instance publicly without any kind of authentication. Summary When uploading a file or retrieving the filename, a user may intentionally use a large Unicode filename which would lead to a application-level denial of service. This is due to no limitation set on the length of the filename and the costy use of the Unicode normalization with the form NFKD under the hood of `secure_filename()`. I idenfied multiple vulnerable paths on blakeblackshear/frigate repository. In all of those paths, it was possible for a malicious user to send a filename equals to the output of : `python3 -c "print('℀' * 1_000_000)"` which would reach the werkzeug `secure_filename()` call , which in turn under the hood uses a compatibility Unicode normalization with NFKC/NFKD form. In sum, the latter call would be costly in matter of CPU resource and may lead to the application-level denial of service. Vulnerable Paths Path with 2 steps 1. frigate/api/media.py @MediaBp.route("/&lt;camera_name&gt;/start/&lt;int:start_ts&gt;/end/&lt;int:end_ts&gt;/clip.mp4") @MediaBp.route("/&lt;camera_name&gt;/start/&lt;float:start_ts&gt;/end/&lt;float:end_ts&gt;/clip.mp4") def recording_clip(camera_name, start_ts, end_ts): download = request.args.get("download", type=bool) 2. frigate/api/media.py playlist_lines.append(f"outpoint {int(end_ts - clip.start_time)}") file_name = secure_filename(f"clip_{camera_name}_{start_ts}-{end_ts}.mp4") path = os.path.join(CACHE_DIR, file_name) ---------------------------------------- frigate/api/media.py playlist_lines.append(f"outpoint {int(end_ts - clip.start_time)}") file_name = secure_filename(f"clip_{camera_name}_{start_ts}-{end_ts}.mp4") path = os.path.join(CACHE_DIR, file_name) *This user-provided value can reach a costly Unicode normalization operation.* Paths Path with 2 steps 1. frigate/api/media.py @MediaBp.route("/&lt;camera_name&gt;/start/&lt;int:start_ts&gt;/end/&lt;int:end_ts&gt;/clip.mp4") @MediaBp.route("/&lt;camera_name&gt;/start/&lt;float:start_ts&gt;/end/&lt;float:end_ts&gt;/clip.mp4") def recording_clip(camera_name, start_ts, end_ts): download = request.args.get("download", type=bool) 2. frigate/api/media.py playlist_lines.append(f"outpoint {int(end_ts - clip.start_time)}") file_name = secure_filename(f"clip_{camera_name}_{start_ts}-{end_ts}.mp4") path = os.path.join(CACHE_DIR, file_name) ---------------------------------------- frigate/api/media.py playlist_lines.append(f"outpoint {int(end_ts - clip.start_time)}") file_name = secure_filename(f"clip_{camera_name}_{start_ts}-{end_ts}.mp4") path = os.path.join(CACHE_DIR, file_name) *This user-provided value can reach a costly Unicode normalization operation.* Paths Path with 2 steps 1. frigate/api/media.py @MediaBp.route("/&lt;camera_name&gt;/start/&lt;int:start_ts&gt;/end/&lt;int:end_ts&gt;/clip.mp4") @MediaBp.route("/&lt;camera_name&gt;/start/&lt;float:start_ts&gt;/end/&lt;float:end_ts&gt;/clip.mp4") def recording_clip(camera_name, start_ts, end_ts): download = request.args.get("download", type=bool) 2. frigate/api/media.py playlist_lines.append(f"outpoint {int(end_ts - clip.start_time)}") file_name = secure_filename(f"clip_{camera_name}_{start_ts}-{end_ts}.mp4") path = os.path.join(CACHE_DIR, file_name) ---------------------------------------- frigate/api/media.py current_app.frigate_config, camera_name, secure_filename(name.replace(" ", "_")) if name else None, int(start_time), int(end_time), *This user-provided value can reach a costly Unicode normalization operation.* Paths Path with 8 steps 1. frigate/api/media.py jsonify, make_response, request, ) from peewee import DoesNotExist, fn 2. frigate/api/media.py jsonify, make_response, request, ) from peewee import DoesNotExist, fn 3. frigate/api/media.py ) json: dict[str, any] = request.get_json(silent=True) or {} playback_factor = json.get("playback", "realtime") name: Optional[str] = json.get("name") 4. [frigate/api/media.py](https://github.com/blakeblackshear/frigate/blob/d7ae0…