GitHub Advisoryadvisory · PyPI
GHSA-w7pp-m8wf-vj6r Cipher.update_into can corrupt memory if passed an immutable python object as the outbuf
MEDIUM
Official page ↗
- Aliases
- CVE-2023-23931
- Ecosystem
- PyPI
- Packages
- cryptography
- Severity
- Moderate
- CVSS vector
- CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:L/A:L
- Weaknesses
- CWE-754
- Reviewed
- 2023-02-07
Affected packages
• PyPI cryptography: >= 1.8, < 39.0.1 → fixed in 39.0.1
Description
Previously, `Cipher.update_into` would accept Python objects which implement the buffer protocol, but provide only immutable buffers:
```pycon
>>> outbuf = b"\x00" * 32
>>> c = ciphers.Cipher(AES(b"\x00" * 32), modes.ECB()).encryptor()
>>> c.update_into(b"\x00" * 16, outbuf)
16
>>> outbuf
b'\xdc\x95\xc0x\xa2@\x89\x89\xadH\xa2\x14\x92\x84 \x87\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00'
```
This would allow immutable objects (such as `bytes`) to be mutated, thus violating fundamental rules of Python. This is a soundness bug -- it allows programmers to misuse an API, it cannot be exploited by attacker controlled data alone.
This now correctly raises an exception.
This issue has been present since `update_into` was originally introduced in cryptography 1.8.
Related
Alias · CVE (1)
- CVE-2023-23931 cryptography is a package designed to expose cryptographic primitives and recipes to Python developers. vulnerability
Weakness · CWE (1)
- CWE-754 Improper Check for Unusual or Exceptional Conditions weakness
References
- https://github.com/pyca/cryptography/security/advisories/GHSA-w7pp-m8wf-vj6r web
- https://nvd.nist.gov/vuln/detail/CVE-2023-23931 advisory
- https://github.com/pyca/cryptography/pull/8230 web
- https://github.com/pyca/cryptography/commit/d6951dca25de45abd52da51b608055371fbcde4e web
- https://github.com/pyca/cryptography package
- https://github.com/pypa/advisory-database/tree/main/vulns/cryptography/PYSEC-2023-11.yaml web
- https://lists.debian.org/debian-lts-announce/2024/10/msg00012.html web
- https://security.netapp.com/advisory/ntap-20230324-0007 web