GitHub Advisoryadvisory · npm
GHSA-wprv-93r4-jj2p OpenZeppelin Contracts using MerkleProof multiproofs may allow proving arbitrary leaves for specific trees
MEDIUM
Official page ↗
- Aliases
- CVE-2023-34459
- Ecosystem
- npm
- Packages
- @openzeppelin/contracts, @openzeppelin/contracts-upgradeable
- Severity
- Moderate
- CVSS vector
- CVSS:3.1/AV:N/AC:H/PR:L/UI:N/S:U/C:N/I:H/A:N
- Weaknesses
- CWE-354
- Reviewed
- 2023-06-19
Affected packages
• npm @openzeppelin/contracts: >= 4.7.0, < 4.9.2 → fixed in 4.9.2
• npm @openzeppelin/contracts-upgradeable: >= 4.7.0, < 4.9.2 → fixed in 4.9.2
Description
Impact
When the `verifyMultiProof`, `verifyMultiProofCalldata`, `processMultiProof`, or `processMultiProofCalldata` functions are in use, it is possible to construct merkle trees that allow forging a valid multiproof for an arbitrary set of leaves.
A contract may be vulnerable if it uses multiproofs for verification and the merkle tree that is processed includes a node with value 0 at depth 1 (just under the root). This could happen inadvertently for balanced trees with 3 leaves or less, if the leaves are not hashed. This could happen deliberately if a malicious tree builder includes such a node in the tree.
A contract is not vulnerable if it uses single-leaf proving (`verify`, `verifyCalldata`, `processProof`, or `processProofCalldata`), or if it uses multiproofs with a known tree that has hashed leaves. Standard merkle trees produced or validated with the @openzeppelin/merkle-tree library are safe.
Patches
The problem has been patched in 4.9.2.
Workarounds
If you are using multiproofs: When constructing merkle trees hash the leaves and do not insert empty nodes in your trees. Using the @openzeppelin/merkle-tree package eliminates this issue. Do not accept user-provided merkle roots without reconstructing at least the first level of the tree. Verify the merkle tree structure by reconstructing it from the leaves.
Related
Alias · CVE (1)
- CVE-2023-34459 OpenZeppelin Contracts is a library for smart contract development. vulnerability
Weakness · CWE (1)
- CWE-354 Improper Validation of Integrity Check Value weakness
References
- https://github.com/OpenZeppelin/openzeppelin-contracts/security/advisories/GHSA-wprv-93r4-jj2p web
- https://nvd.nist.gov/vuln/detail/CVE-2023-34459 advisory
- https://github.com/OpenZeppelin/openzeppelin-contracts/commit/4d2383e17186be3e8ccf5a442e9686ecc7de1c55 web
- https://github.com/OpenZeppelin/openzeppelin-contracts package
- https://github.com/OpenZeppelin/openzeppelin-contracts/releases/tag/v4.9.2 web