GitHub Advisoryadvisory · Go

GHSA-xgr7-jgq3-mhmc Contract balance not updating correctly after interchain transaction

HIGH Published 2024-06-06 Modified 2024-06-17 Official page ↗
Aliases
CVE-2024-37153
Ecosystem
Go
Packages
github.com/evmos/evmos/v18, github.com/evmos/evmos/v17, github.com/evmos/evmos/v16, github.com/evmos/evmos/v15, github.com/evmos/evmos/v14, github.com/evmos/evmos/v13, github.com/evmos/evmos/v12, github.com/evmos/evmos/v11, github.com/evmos/evmos/v10, github.com/evmos/evmos/v9, github.com/evmos/evmos/v8, github.com/evmos/evmos/v7, github.com/evmos/evmos/v6
Severity
High
CVSS vector
CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:H/A:N
Weaknesses
CWE-670
Reviewed
2024-06-06

Affected packages

• Go github.com/evmos/evmos/v18: < 18.1.0 → fixed in 18.1.0 • Go github.com/evmos/evmos/v17: < 18.1.0 → fixed in 18.1.0 • Go github.com/evmos/evmos/v16: < 18.1.0 → fixed in 18.1.0 • Go github.com/evmos/evmos/v15: < 18.1.0 → fixed in 18.1.0 • Go github.com/evmos/evmos/v14: < 18.1.0 → fixed in 18.1.0 • Go github.com/evmos/evmos/v13: < 18.1.0 → fixed in 18.1.0 • Go github.com/evmos/evmos/v12: < 18.1.0 → fixed in 18.1.0 • Go github.com/evmos/evmos/v11: < 18.1.0 → fixed in 18.1.0 • Go github.com/evmos/evmos/v10: < 18.1.0 → fixed in 18.1.0 • Go github.com/evmos/evmos/v9: < 18.1.0 → fixed in 18.1.0 • Go github.com/evmos/evmos/v8: < 18.1.0 → fixed in 18.1.0 • Go github.com/evmos/evmos/v7: < 18.1.0 → fixed in 18.1.0 • Go github.com/evmos/evmos/v6: < 18.1.0 → fixed in 18.1.0

Description

Summary _Short summary of the problem. Make the impact and severity as clear as possible. For example: An unsafe deserialization vulnerability allows any unauthenticated user to execute arbitrary code on the server._ Details We discovered a bug walking through how to liquid stake using Safe which itself is a contract. The bug only appears when there is a local state change together with an ICS20 transfer in the same function and uses the contract's balance, that is using the contract address as the `sender` parameter in an ICS20 transfer using the ICS20 precompile Proof of Concept ```solidity // This function does not reduce the contract balance correctly but liquid stakes correctly function transfer( string memory sourcePort, string memory sourceChannel, string memory denom, uint256 amount, string memory receiver, string memory evmosReceiver ) external returns (uint64 nextSequence) { counter += 1; # Only happens when there is a local state update together with an ICS20 Transfer Height memory timeoutHeight = Height(100, 100); string memory memo = buildLiquidStakeMemo(receiver, evmosReceiver); return ICS20_CONTRACT.transfer( sourcePort, sourceChannel, denom, amount, address(this), # this is the sender address which is the contract receiver, timeoutHeight, 0, memo ); } ``` Impact This is in essence the "infinite money glitch" allowing contracts to double the supply of Evmos after each transaction. Severity Based on ImmuneFi Severity Classification System the severity was evaluated to `Critical` since the attack could have lead to create new supply of EVMOS and therefore lead to Direct loss of funds's value. Patches The issue has been patched in versions >=V18.1.0. For more information If you have any questions or comments about this advisory: Reach out to the Core Team in Discord Open a discussion in evmos/evmos Email us at [email protected] for security questions

Related

Alias · CVE (1)

  • CVE-2024-37153 Evmos is the Ethereum Virtual Machine (EVM) Hub on the Cosmos Network. vulnerability

Weakness · CWE (1)

  • CWE-670 Always-Incorrect Control Flow Implementation weakness

References