GitHub Advisoryadvisory · PyPI
GHSA-xrp2-fhq4-4q3w Segfault if `tf.histogram_fixed_width` is called with NaN values in TensorFlow
MEDIUM
Official page ↗
- Aliases
- CVE-2022-29211
- Ecosystem
- PyPI
- Packages
- tensorflow, tensorflow-cpu, tensorflow-gpu
- Severity
- Moderate
- CVSS vector
- CVSS:3.1/AV:L/AC:L/PR:L/UI:N/S:U/C:N/I:N/A:H
- Weaknesses
- CWE-20
- Reviewed
- 2022-05-24
Affected packages
• PyPI tensorflow: < 2.6.4 → fixed in 2.6.4
• PyPI tensorflow: >= 2.7.0, < 2.7.2 → fixed in 2.7.2
• PyPI tensorflow: >= 2.8.0, < 2.8.1 → fixed in 2.8.1
• PyPI tensorflow-cpu: < 2.6.4 → fixed in 2.6.4
• PyPI tensorflow-cpu: >= 2.7.0, < 2.7.2 → fixed in 2.7.2
• PyPI tensorflow-cpu: >= 2.8.0, < 2.8.1 → fixed in 2.8.1
• PyPI tensorflow-gpu: < 2.6.4 → fixed in 2.6.4
• PyPI tensorflow-gpu: >= 2.7.0, < 2.7.2 → fixed in 2.7.2
• PyPI tensorflow-gpu: >= 2.8.0, < 2.8.1 → fixed in 2.8.1
Description
Impact
The implementation of `tf.histogram_fixed_width` is vulnerable to a crash when the values array contain `NaN` elements:
```python
import tensorflow as tf
import numpy as np
tf.histogram_fixed_width(values=np.nan, value_range=[1,2])
```
The implementation assumes that all floating point operations are defined and then converts a floating point result to an integer index:
```cc
index_to_bin.device(d) =
((values.cwiseMax(value_range(0)) - values.constant(value_range(0)))
.template cast() /
step)
.cwiseMin(nbins_minus_1)
.template cast();
```
If `values` contains `NaN` then the result of the division is still `NaN` and the cast to `int32` would result in a crash.
This only occurs on the CPU implementation.
Patches
We have patched the issue in GitHub commit e57fd691c7b0fd00ea3bfe43444f30c1969748b5.
The fix will be included in TensorFlow 2.9.0. We will also cherrypick this commit on TensorFlow 2.8.1, TensorFlow 2.7.2, and TensorFlow 2.6.4, as these are also affected and still in supported range.
For more information
Please consult our security guide for more information regarding the security model and how to contact us with issues and questions.
Attribution
This vulnerability has been reported externally via a GitHub issue.
Related
Alias · CVE (1)
- CVE-2022-29211 TensorFlow is an open source platform for machine learning. vulnerability
Weakness · CWE (1)
- CWE-20 Improper Input Validation weakness
References
- https://github.com/tensorflow/tensorflow/security/advisories/GHSA-xrp2-fhq4-4q3w web
- https://nvd.nist.gov/vuln/detail/CVE-2022-29211 advisory
- https://github.com/tensorflow/tensorflow/issues/45770 web
- https://github.com/tensorflow/tensorflow/commit/e57fd691c7b0fd00ea3bfe43444f30c1969748b5 web
- https://github.com/tensorflow/tensorflow package
- https://github.com/tensorflow/tensorflow/blob/f3b9bf4c3c0597563b289c0512e98d4ce81f886e/tensorflow/core/kernels/histogram_op.cc web
- https://github.com/tensorflow/tensorflow/blob/f3b9bf4c3c0597563b289c0512e98d4ce81f886e/tensorflow/core/kernels/histogram_op.cc#L35-L74 web
- https://github.com/tensorflow/tensorflow/releases/tag/v2.6.4 web
- https://github.com/tensorflow/tensorflow/releases/tag/v2.7.2 web
- https://github.com/tensorflow/tensorflow/releases/tag/v2.8.1 web
- https://github.com/tensorflow/tensorflow/releases/tag/v2.9.0 web