GitHub Advisoryadvisory · Go
GHSA-8pgv-569h-w5rw otelgrpc DoS vulnerability due to unbound cardinality metrics
HIGH
Official page ↗
- Aliases
- CVE-2023-47108
- Ecosystem
- Go
- Packages
- go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc
- Severity
- High
- CVSS vector
- CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:H
- Weaknesses
- CWE-770
- Reviewed
- 2023-11-12
Affected packages
• Go go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc: >= 0.37.0, < 0.46.0 → fixed in 0.46.0
Description
Summary
The grpc Unary Server Interceptor opentelemetry-go-contrib/instrumentation/google.golang.org/grpc/otelgrpc/interceptor.go
```
// UnaryServerInterceptor returns a grpc.UnaryServerInterceptor suitable
// for use in a grpc.NewServer call.
func UnaryServerInterceptor(opts ...Option) grpc.UnaryServerInterceptor {
```
out of the box adds labels
• `net.peer.sock.addr`
• `net.peer.sock.port`
that have unbound cardinality. It leads to the server's potential memory exhaustion when many malicious requests are sent.
Details
An attacker can easily flood the peer address and port for requests.
PoC
Apply the attached patch to the example and run the client multiple times. Observe how each request will create a unique histogram and how the memory consumption increases during it.
Impact
In order to be affected, the program has to configure a metrics pipeline, use UnaryServerInterceptor, and does not filter any client IP address and ports via middleware or proxies, etc.
Others
It is similar to already reported vulnerabilities.
• GHSA-rcjv-mgp8-qvmr (open-telemetry/opentelemetry-go-contrib)
• [GHSA-5r5m-65gx-7vrh](https://github.com/open-telemetry/opentelemetry-go-contrib/security/advisories/GHSA-5r5m-65gx-7vrh "GHSA-5r5m-65gx-7vrh") (open-telemetry/opentelemetry-go-contrib)
• [GHSA-cg3q-j54f-5p7p](https://github.com/advisories/GHSA-cg3q-j54f-5p7p "GHSA-cg3q-j54f-5p7p") (prometheus/client_golang)
Workaround for affected versions
As a workaround to stop being affected, a view removing the attributes can be used.
The other possibility is to disable grpc metrics instrumentation by passing `otelgrpc.WithMeterProvider` option with `noop.NewMeterProvider`.
Solution provided by upgrading
In PR #4322, to be released with v0.46.0, the attributes were removed.
References
• #4322
Related
Alias · CVE (1)
- CVE-2023-47108 OpenTelemetry-Go Contrib is a collection of third-party packages for OpenTelemetry-Go. vulnerability
Weakness · CWE (1)
- CWE-770 Allocation of Resources Without Limits or Throttling weakness
References
- https://github.com/open-telemetry/opentelemetry-go-contrib/security/advisories/GHSA-8pgv-569h-w5rw web
- https://nvd.nist.gov/vuln/detail/CVE-2023-47108 advisory
- https://github.com/open-telemetry/opentelemetry-go-contrib/pull/4322 web
- https://github.com/open-telemetry/opentelemetry-go-contrib/commit/04c5dcbb5b35f14b4e6793b245919c72addbc7d0 web
- https://github.com/open-telemetry/opentelemetry-go-contrib/commit/b44dfc9092b157625a5815cb437583cee663333b web
- https://github.com/open-telemetry/opentelemetry-go-contrib package
- https://github.com/open-telemetry/opentelemetry-go-contrib/blob/9d4eb7e7706038b07d33f83f76afbe13f53d171d/instrumentation/google.golang.org/grpc/otelgrpc/interceptor.go#L327 web
- https://github.com/open-telemetry/opentelemetry-go-contrib/blob/instrumentation/google.golang.org/grpc/otelgrpc/v0.45.0/instrumentation/google.golang.org/grpc/otelgrpc/config.go#L138 web
- https://pkg.go.dev/go.opentelemetry.io/otel/metric/noop#NewMeterProvider web