GitHub Advisoryadvisory · PyPI
GHSA-cx2q-hfxr-rj97 Vyper's `_abi_decode` input not validated in complex expressions
MEDIUM
Official page ↗
- Aliases
- CVE-2023-42460
- Ecosystem
- PyPI
- Packages
- vyper
- Severity
- Moderate
- CVSS vector
- CVSS:3.1/AV:N/AC:H/PR:L/UI:N/S:U/C:N/I:H/A:N
- Weaknesses
- CWE-682
- Reviewed
- 2023-09-26
Affected packages
• PyPI vyper: >= 0.3.4, < 0.3.10 → fixed in 0.3.10
Description
Impact
`_abi_decode()` does not validate input when it is nested in an expression. the following example gets correctly validated (bounds checked):
```vyper
x: int128 = _abi_decode(slice(msg.data, 4, 32), int128)
```
however, the following example is not bounds checked
```vyper
@external
def abi_decode(x: uint256) -> uint256:
a: uint256 = convert(_abi_decode(slice(msg.data, 4, 32), (uint8)), uint256) + 1
return a # abi_decode(256) returns: 257
```
the issue can be triggered by constructing an example where the output of `_abi_decode` is not internally passed to `make_setter` (an internal codegen routine) or other input validating routine.
Patches
https://github.com/vyperlang/vyper/pull/3626
Workarounds
_Is there a way for users to fix or remediate the vulnerability without upgrading?_
References
_Are there any links users can visit to find out more?_
Related
Alias · CVE (1)
- CVE-2023-42460 Vyper is a Pythonic Smart Contract Language for the EVM. vulnerability
Weakness · CWE (1)
- CWE-682 Incorrect Calculation weakness
References
- https://github.com/vyperlang/vyper/security/advisories/GHSA-cx2q-hfxr-rj97 web
- https://nvd.nist.gov/vuln/detail/CVE-2023-42460 advisory
- https://github.com/vyperlang/vyper/pull/3626 web
- https://github.com/pypa/advisory-database/tree/main/vulns/vyper/PYSEC-2023-191.yaml web
- https://github.com/vyperlang/vyper package